Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add tests for Dashboard Header and HeaderActionsDropdown components #13973

Merged
merged 14 commits into from
Apr 14, 2021
Merged

test: Add tests for Dashboard Header and HeaderActionsDropdown components #13973

merged 14 commits into from
Apr 14, 2021

Conversation

geido
Copy link
Member

@geido geido commented Apr 6, 2021

SUMMARY

Adds and enhances the test cases for the Dashboard Header and HeaderActionsDropdown components.

TEST PLAN

All tests should pass

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Apr 7, 2021
@geido geido marked this pull request as ready for review April 7, 2021 16:03
@geido
Copy link
Member Author

geido commented Apr 7, 2021

@junlincc @rusackas

@codecov
Copy link

codecov bot commented Apr 7, 2021 •
edited
Loading

Codecov Report

Merging #13973 (51c036d) into master (a548b69) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 51c036d differs from pull request most recent head a64fa0d. Consider uploading reports for the commit a64fa0d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13973      +/-   ##
==========================================
+ Coverage   79.78%   79.83%   +0.05%     
==========================================
  Files         943      943              
  Lines       47748    47748              
  Branches     6026     6016      -10     
==========================================
+ Hits        38094    38121      +27     
+ Misses       9533     9508      -25     
+ Partials      121      119       -2
Flag Coverage Δ
cypress 56.36% <ø> (-0.01%) ⬇️
javascript 70.17% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/Header/HeaderActionsDropdown/index.jsx 72.36% <ø> (ø)
...frontend/src/dashboard/components/Header/index.jsx 81.02% <ø> (ø)
...dashboard/components/SliceHeaderControls/index.jsx 78.35% <0.00%> (-1.04%) ⬇️
...et-frontend/src/components/EditableTitle/index.tsx 86.41% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a548b69...a64fa0d. Read the comment docs.

@geido geido closed this Apr 9, 2021
@geido geido reopened this Apr 9, 2021
@rusackas
Copy link
Member

/testenv up

@rusackas
Copy link
Member

Unit tests aren't passing, and needs a little rebase, but this is looking SUPER close to golden!

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.217.14.169:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas
rusackas approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 474f1e2 into apache:master Apr 14, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@geido
test: Add tests for Dashboard Header and HeaderActionsDropdown compon…
cf34a13 
…ents (apache#13973)

* Add tests for HeaderActionsDropdown - WIP

* Fix trigger node

* Add types

* Clean up

* Add tests for Header

* Delete obsolete tests

* Add factory and clean up

* Add opposite case

* Fix file name

* Include latest changes
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yardz yardz yardz left review comments

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL test:component v1.2 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geido @rusackas @yardz @mistercrunch @amitmiran137