Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moves WarningIconWithTooltip to own folder #14123

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Moves WarningIconWithTooltip to own folder and creates a storybook for it.
  • Removes TableSelector.less

No tests were added because this component will be merged with CertifiedIcon, ChartIcon, FaveStar, IconTooltip, RefreshLabel, WarningIconWithTooltip.

This work is part of SIP-61

@rusackas @junlincc

TEST PLAN

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #14123 (27fa741) into master (c760030) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 27fa741 differs from pull request most recent head 54ebf62. Consider uploading reports for the commit 54ebf62 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14123   +/-   ##
=======================================
  Coverage   77.01%   77.01%           
=======================================
  Files         954      954           
  Lines       48071    48072    +1     
  Branches     5973     5973           
=======================================
+ Hits        37024    37025    +1     
  Misses      10850    10850           
  Partials      197      197           
Flag Coverage Δ
javascript 72.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/components/WarningIconWithTooltip/index.tsx 90.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c760030...54ebf62. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTG. Need to rebase! =)

@michael-s-molina michael-s-molina force-pushed the tests-audit-warning-icon branch from 5a51fc9 to 54ebf62 Compare April 22, 2021 13:31
@rusackas rusackas merged commit 3e23c10 into apache:master Apr 22, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants