Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switching to local codecov script #14170

Merged
merged 4 commits into from
Apr 16, 2021

Conversation

craig-rueda
Copy link
Member

SUMMARY

In light of recent issues with the remote codecov bash script, this PR downloads the script locally and migrates CI actions to utilize the local script instead.

TEST PLAN

This should only affect CI, so passing workflows should suffice

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although i didn't review the bash script itself :P

perhaps we should also add instructions to the script's comment block on how to update in the future if needed?

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #14170 (c87a170) into master (8ef572a) will increase coverage by 0.50%.
The diff coverage is 71.33%.

❗ Current head c87a170 differs from pull request most recent head 3064d6c. Consider uploading reports for the commit 3064d6c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14170      +/-   ##
==========================================
+ Coverage   79.07%   79.58%   +0.50%     
==========================================
  Files         943      945       +2     
  Lines       48353    47920     -433     
  Branches     6246     6067     -179     
==========================================
- Hits        38237    38136     -101     
+ Misses       9977     9660     -317     
+ Partials      139      124      -15     
Flag Coverage Δ
hive ?
mysql 80.65% <69.33%> (-0.11%) ⬇️
postgres ?
presto ?
python 80.68% <69.33%> (-0.67%) ⬇️
sqlite 80.28% <69.33%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.28% <ø> (ø)
...-frontend/src/components/CronPicker/CronPicker.tsx 91.66% <ø> (ø)
...perset-frontend/src/components/CronPicker/index.ts 100.00% <ø> (ø)
...t-frontend/src/components/DropdownButton/index.tsx 24.00% <ø> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/components/Switch/index.tsx 100.00% <ø> (ø)
superset-frontend/src/views/CRUD/alert/types.ts 100.00% <ø> (ø)
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx 77.08% <ø> (ø)
...frontend/src/views/CRUD/welcome/DashboardTable.tsx 63.63% <ø> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <ø> (ø)
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef572a...3064d6c. Read the comment docs.

@craig-rueda craig-rueda merged commit 8db7be1 into apache:master Apr 16, 2021
@craig-rueda craig-rueda deleted the craig/download-codecov branch April 16, 2021 16:26
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* Switching to local codecov script

* Adding license / update instructions

* Fixing FE build

* Fixing FE codecov test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XXL 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants