-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Switching to local codecov script #14170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, although i didn't review the bash script itself :P
perhaps we should also add instructions to the script's comment block on how to update in the future if needed?
Codecov Report
@@ Coverage Diff @@
## master #14170 +/- ##
==========================================
+ Coverage 79.07% 79.58% +0.50%
==========================================
Files 943 945 +2
Lines 48353 47920 -433
Branches 6246 6067 -179
==========================================
- Hits 38237 38136 -101
+ Misses 9977 9660 -317
+ Partials 139 124 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Switching to local codecov script * Adding license / update instructions * Fixing FE build * Fixing FE codecov test
SUMMARY
In light of recent issues with the remote codecov bash script, this PR downloads the script locally and migrates CI actions to utilize the local script instead.
TEST PLAN
This should only affect CI, so passing workflows should suffice
ADDITIONAL INFORMATION