Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: type some SQL Lab components #14178

Merged
merged 2 commits into from
Apr 16, 2021
Merged

chore: type some SQL Lab components #14178

merged 2 commits into from
Apr 16, 2021

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Apr 16, 2021

SUMMARY

Continue the push towards 100% TypeScript

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue: [TRACKER] Migrate JavaScript files to TypeScript #10004
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @ktmud @betodealmeida @rusackas @nytai

@codecov
Copy link

codecov bot commented Apr 16, 2021 •
edited
Loading

Codecov Report

Merging #14178 (4e11e28) into master (df7e2b6) will increase coverage by 0.06%.
The diff coverage is 75.00%.

❗ Current head 4e11e28 differs from pull request most recent head 9b99147. Consider uploading reports for the commit 9b99147 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14178      +/-   ##
==========================================
+ Coverage   79.80%   79.87%   +0.06%     
==========================================
  Files         943      944       +1     
  Lines       47874    47919      +45     
  Branches     6042     6069      +27     
==========================================
+ Hits        38204    38273      +69     
+ Misses       9548     9522      -26     
- Partials      122      124       +2
Flag Coverage Δ
cypress 56.30% <59.09%> (-0.01%) ⬇️
javascript 70.25% <82.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.28% <ø> (ø)
...-frontend/src/components/CronPicker/CronPicker.tsx 91.66% <ø> (ø)
...perset-frontend/src/components/CronPicker/index.ts 100.00% <ø> (ø)
...t-frontend/src/components/DropdownButton/index.tsx 24.00% <ø> (ø)
superset-frontend/src/components/Switch/index.tsx 100.00% <ø> (ø)
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx 77.08% <ø> (ø)
...frontend/src/views/CRUD/welcome/DashboardTable.tsx 63.63% <ø> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <ø> (ø)
superset/viz.py 55.59% <0.00%> (-0.07%) ⬇️
...et-frontend/src/SqlLab/components/QueryHistory.tsx 66.66% <25.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7e2b6...9b99147. Read the comment docs.

michael-s-molina
michael-s-molina approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Optional suggestion 😉

@etr2460 etr2460 merged commit 01f13c5 into apache:master Apr 16, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@michael-s-molina
chore: type some SQL Lab components (apache#14178)
c391d79 
* chore: type some SQL Lab components

* Update superset-frontend/src/SqlLab/components/QueryHistory.tsx

Co-authored-by: Michael S. Molina <[email protected]>

Co-authored-by: Michael S. Molina <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktmud ktmud ktmud approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etr2460 @ktmud @michael-s-molina @mistercrunch