Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add extra requires for shillelagh #14180

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Apr 16, 2021

SUMMARY

I'm not a python expert, but while trying to enable the gsheets API, I got the error No module named 'google.auth'. It looks like we need to add the extra require from shillelagh like this, but i'm not positive that this is the right syntax. I'm hoping CI will help me out, but i'll also test this locally to see if it fixes the issue

Also updates some documentation

TEST PLAN

CI, dev

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @betodealmeida

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #14180 (f24e1d4) into master (df7e2b6) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

❗ Current head f24e1d4 differs from pull request most recent head 1b082ef. Consider uploading reports for the commit 1b082ef to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14180      +/-   ##
==========================================
- Coverage   79.80%   79.79%   -0.01%     
==========================================
  Files         943      944       +1     
  Lines       47874    47916      +42     
  Branches     6042     6067      +25     
==========================================
+ Hits        38204    38233      +29     
- Misses       9548     9559      +11     
- Partials      122      124       +2     
Flag Coverage Δ
hive 80.37% <0.00%> (-0.01%) ⬇️
mysql 80.64% <0.00%> (-0.01%) ⬇️
postgres 80.67% <0.00%> (-0.01%) ⬇️
python 81.07% <0.00%> (-0.01%) ⬇️
sqlite 80.27% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.28% <ø> (ø)
...-frontend/src/components/CronPicker/CronPicker.tsx 91.66% <ø> (ø)
...perset-frontend/src/components/CronPicker/index.ts 100.00% <ø> (ø)
...t-frontend/src/components/DropdownButton/index.tsx 24.00% <ø> (ø)
superset-frontend/src/components/Switch/index.tsx 100.00% <ø> (ø)
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx 77.08% <ø> (ø)
...frontend/src/views/CRUD/welcome/DashboardTable.tsx 63.63% <ø> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <ø> (ø)
superset/viz.py 55.59% <0.00%> (-0.07%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 84.32% <80.00%> (-0.17%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7e2b6...1b082ef. Read the comment docs.

@villebro villebro requested a review from betodealmeida April 16, 2021 04:49
@villebro
Copy link
Member

LGTM but I'd prefer for @betodealmeida to confirm!

@etr2460
Copy link
Member Author

etr2460 commented Apr 16, 2021

I verified that installing now includes google.auth and querying from sql lab works

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, sorry for missing that!

@etr2460 etr2460 merged commit a3e3023 into master Apr 16, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix: Add extra requires for shillelagh

* Update google-sheets.mdx

* Update index.mdx
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
@mistercrunch mistercrunch deleted the erik-ritter--fix-gsheets branch March 26, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants