-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add extra requires for shillelagh #14180
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14180 +/- ##
==========================================
- Coverage 79.80% 79.79% -0.01%
==========================================
Files 943 944 +1
Lines 47874 47916 +42
Branches 6042 6067 +25
==========================================
+ Hits 38204 38233 +29
- Misses 9548 9559 +11
- Partials 122 124 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LGTM but I'd prefer for @betodealmeida to confirm! |
I verified that installing now includes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, sorry for missing that!
* fix: Add extra requires for shillelagh * Update google-sheets.mdx * Update index.mdx
SUMMARY
I'm not a python expert, but while trying to enable the gsheets API, I got the error
No module named 'google.auth'
. It looks like we need to add the extra require from shillelagh like this, but i'm not positive that this is the right syntax. I'm hoping CI will help me out, but i'll also test this locally to see if it fixes the issueAlso updates some documentation
TEST PLAN
CI, dev
ADDITIONAL INFORMATION
to: @betodealmeida