Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(native-filters): fix remove native filters #14218

Merged
merged 4 commits into from
Apr 20, 2021
Merged

fix(native-filters): fix remove native filters #14218

merged 4 commits into from
Apr 20, 2021

Conversation

simcha90
Copy link
Contributor

SUMMARY

Bug: When remove native filter form filter bar it's data still saved in dashboard

Steps reproduce:

  1. Add native filter
  2. Apply it's value
  3. Remove it from filter bar

Actual: Charts not affected
Expected: Dashboard data should be updated

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@amitmiran137 amitmiran137 requested a review from villebro April 18, 2021 17:12
@villebro villebro changed the title fix(native-filters): fix remove native fitlers fix(native-filters): fix remove native filters Apr 20, 2021
@villebro villebro merged commit 9d67b46 into apache:master Apr 20, 2021
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Apr 28, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@simcha90
fix(native-filters): fix remove native filters (apache#14218)
55ce547 
* fix:fix get permission function

* fix: clean data mask on chart removing

* refactor: fix reducer
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/S v1.2 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simcha90 @villebro @mistercrunch @amitmiran137 @junlincc