feat: Setup supersetText configuration to overwrite errors
#14256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
force-pushed
the
hugh/overwrite-generic-errors
branch
from
8f5eacd to
5e19aa7
Compare
hughhhh
changed the title
supersetText configuration to overwrite errorssupersetText configuration to overwrite errors
eschutho
reviewed
Apr 21, 2021
| @@ -18,14 +18,14 @@ | |||
| */ | |||
| import React, { FunctionComponent, useState, useEffect } from 'react'; | |||
| import { styled, t } from '@superset-ui/core'; | |||
| import InfoTooltip from 'src/common/components/InfoTooltip'; | |||
| import InfoTooltip from 'src/components/InfoTooltip'; | |||
There was a problem hiding this comment.
you should be able to rebase and get these changes in.
eschutho
reviewed
Apr 21, 2021
superset/config.py
Outdated
| # to AES-128 under the covers using the app's SECRET_KEY as key material. | ||
| # | ||
| # pylint: disable=C0103 | ||
| SQLALCHEMY_ENCRYPTED_FIELD_TYPE_ADAPTER = SQLAlchemyUtilsAdapter |
eschutho
reviewed
Apr 21, 2021
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import supersetText from '../../../superset_text.yaml'; |
There was a problem hiding this comment.
I'm going to see about importing this in a different way in case the file doesn't exist so that there's no error.
Codecov Report
@@ Coverage Diff @@
## master #14256 +/- ##
==========================================
+ Coverage 76.93% 77.07% +0.14%
==========================================
Files 954 957 +3
Lines 48070 48457 +387
Branches 5973 6141 +168
==========================================
+ Hits 36982 37349 +367
- Misses 10886 10910 +24
+ Partials 202 198 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…/overwrite-generic-errors
hughhhh
changed the title
supersetText configuration to overwrite errorssupersetText configuration to overwrite errors
betodealmeida
approved these changes
Apr 27, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…14256) * Setup error message overwrite config` * fix * bad reabse * bad rebase 2 * remove unneeded comment * working dynamic importing * saveeee * working textUtil file * add ignore tslint * fix linting * fix linting * import order * setup guard statements * linting again * linting again Co-authored-by: Elizabeth Thompson <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We want to create an interface to allow us to overwrite specific error messages in superset. So we've create a config that allow you to overwrite specific error message coming back from the API.
This is built on top of SIP-40 + SIP-41
By adding a superset_text.yaml with the following structure you'll be able to overwrite and error.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION