Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db2): change engine name and add legacy alias #14295

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

villebro
Copy link
Member

SUMMARY

Currently we only support the legacy engine name ibm_db_sa for DB2. This changes the primary name of the DB2 engine to db2 and adds the ibm_db_sa alias as a fallback per the comment here:

https://github.com/ibmdb/python-ibmdbsa/blob/7c7cef341829a316bf46561920aa5a789f498431/ibm_db_sa/setup.py#L42-L57

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

Ping @ljclour

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #14295 (573e7f8) into master (5d3191b) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14295      +/-   ##
==========================================
+ Coverage   76.93%   77.01%   +0.08%     
==========================================
  Files         954      954              
  Lines       48070    48071       +1     
  Branches     5973     5973              
==========================================
+ Hits        36982    37022      +40     
+ Misses      10886    10847      -39     
  Partials      202      202              
Flag Coverage Δ
hive 80.44% <100.00%> (+<0.01%) ⬆️
mysql 80.73% <100.00%> (+<0.01%) ⬆️
postgres 80.76% <100.00%> (+0.01%) ⬆️
presto 80.46% <100.00%> (?)
python 81.30% <100.00%> (+0.15%) ⬆️
sqlite 80.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/db2.py 91.66% <100.00%> (+0.75%) ⬆️
superset/models/core.py 89.13% <0.00%> (+0.27%) ⬆️
superset/connectors/sqla/models.py 90.07% <0.00%> (+1.45%) ⬆️
superset/db_engine_specs/presto.py 89.89% <0.00%> (+5.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3191b...573e7f8. Read the comment docs.

@villebro villebro merged commit fe1d32d into apache:master Apr 22, 2021
@villebro villebro added the v1.2 label Apr 22, 2021
amitmiran137 pushed a commit that referenced this pull request Apr 22, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS v1.2 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no option in TIME GRAIN
3 participants