Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reorganize dateFilterUtils.tx #14309

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

reorganize dateFilterUtils.tx (no function change)

TEST PLAN

no need more test, only move files.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to SIP-61, going forward we should move specs to src/... alongside the functional code (#13632):

All the specs were moved to the src folder alongside each component/page/hook/etc. The same is valid for mocks. When restructuring we should verify if a mock is shared or belong to a specific module.

Do you think this code could be moved to src/explore/components/controls/DateFilterControl/?

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #14309 (22b3088) into master (0dfb32c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14309   +/-   ##
=======================================
  Coverage   76.99%   76.99%           
=======================================
  Files         953      954    +1     
  Lines       48061    48071   +10     
  Branches     5971     5975    +4     
=======================================
+ Hits        37004    37012    +8     
- Misses      10855    10862    +7     
+ Partials      202      197    -5     
Flag Coverage Δ
javascript 72.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/controls/DateFilterControl/DateFilterLabel.tsx 73.72% <ø> (-0.23%) ⬇️
...ontrols/DateFilterControl/utils/dateFilterUtils.ts 100.00% <ø> (ø)
...ols/DateFilterControl/components/AdvancedFrame.tsx 100.00% <100.00%> (ø)
...nts/controls/DateFilterControl/utils/dateParser.ts 96.15% <100.00%> (ø)
...mponents/controls/DateFilterControl/utils/index.ts 100.00% <100.00%> (ø)
...src/explore/components/controls/VizTypeControl.jsx 79.66% <0.00%> (-1.30%) ⬇️
...ols/FilterControl/AdhocFilterEditPopover/index.jsx 64.81% <0.00%> (-1.19%) ⬇️
superset-frontend/src/profile/components/App.tsx 100.00% <0.00%> (ø)
superset-frontend/src/components/FormRow/index.jsx 100.00% <0.00%> (ø)
superset-frontend/src/components/ListView/types.ts 100.00% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfb32c...22b3088. Read the comment docs.

@zhaoyongjie
Copy link
Member Author

According to SIP-61, going forward we should move specs to src/... alongside the functional code (#13632):

All the specs were moved to the src folder alongside each component/page/hook/etc. The same is valid for mocks. When restructuring we should verify if a mock is shared or belong to a specific module.

Do you think this code could be moved to src/explore/components/controls/DateFilterControl/?

Thanks for pointing that. I have moved test files to component directory

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit 67535bb into apache:master Apr 23, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* refactor: reorganize dateFilterUtils.tx

* move spec to src dirctory
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants