-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reorganize dateFilterUtils.tx #14309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to SIP-61, going forward we should move specs to src/...
alongside the functional code (#13632):
All the specs were moved to the src folder alongside each component/page/hook/etc. The same is valid for mocks. When restructuring we should verify if a mock is shared or belong to a specific module.
Do you think this code could be moved to src/explore/components/controls/DateFilterControl/
?
Codecov Report
@@ Coverage Diff @@
## master #14309 +/- ##
=======================================
Coverage 76.99% 76.99%
=======================================
Files 953 954 +1
Lines 48061 48071 +10
Branches 5971 5975 +4
=======================================
+ Hits 37004 37012 +8
- Misses 10855 10862 +7
+ Partials 202 197 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks for pointing that. I have moved test files to component directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* refactor: reorganize dateFilterUtils.tx * move spec to src dirctory
SUMMARY
reorganize dateFilterUtils.tx (no function change)
TEST PLAN
no need more test, only move files.
ADDITIONAL INFORMATION