Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select country in examples chart #14561

Merged
merged 1 commit into from
May 11, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

Fix the "Birth in France by department in 2016" chart by selecting "France" as the country.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screenshot_2021-05-10 Birth in France by department in 2016(1)

After:

Screenshot_2021-05-10 Birth in France by department in 2016

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh self-requested a review May 11, 2021 02:03
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #14561 (a277d0c) into master (adbe56c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14561      +/-   ##
==========================================
- Coverage   77.40%   77.40%   -0.01%     
==========================================
  Files         958      958              
  Lines       48326    48326              
  Branches     5677     5677              
==========================================
- Hits        37407    37405       -2     
- Misses      10719    10721       +2     
  Partials      200      200              
Flag Coverage Δ
hive 80.89% <ø> (ø)
mysql 81.15% <ø> (ø)
postgres 81.18% <ø> (ø)
presto 80.88% <ø> (-0.01%) ⬇️
python 81.71% <ø> (-0.01%) ⬇️
sqlite 80.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/country_map.py 26.31% <ø> (ø)
superset/db_engine_specs/presto.py 89.89% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbe56c...a277d0c. Read the comment docs.

@betodealmeida betodealmeida merged commit 09050ae into apache:master May 11, 2021
amitmiran137 pushed a commit that referenced this pull request May 24, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Sep 8, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 1.2.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v1.2 🍒 1.2.0 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants