fix: reindex when combine metric in legacy pivot table

[zhaoyongjie]

SUMMARY

Make metrics order insistence when combine metric checked.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TEST PLAN

tested in my local environment

ADDITIONAL INFORMATION

• Has associated issue: Fixes: [pivot] Order of metrics is incorrect when using 'Combine Metrics' #13427
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #14708 (84d4a88) into master (3f6bd1e) will increase coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #14708      +/-   ##
==========================================
+ Coverage   77.38%   77.55%   +0.16%     
==========================================
  Files         959      959              
  Lines       48465    48528      +63     
  Branches     5678     5678              
==========================================
+ Hits        37506    37634     +128     
+ Misses      10759    10694      -65     
  Partials      200      200              

Flag	Coverage Δ
hive	81.10% <0.00%> (+0.13%)	⬆️
mysql	81.37% <0.00%> (+0.13%)	⬆️
postgres	81.40% <0.00%> (+0.13%)	⬆️
presto	81.10% <0.00%> (?)
python	81.93% <0.00%> (+0.29%)	⬆️
sqlite	81.02% <0.00%> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/viz.py	56.35% <0.00%> (ø)
superset/connectors/base/models.py	88.03% <0.00%> (-2.66%)	⬇️
superset/reports/logs/api.py	94.11% <0.00%> (-1.34%)	⬇️
superset/exceptions.py	98.70% <0.00%> (-1.30%)	⬇️
superset/views/base.py	75.17% <0.00%> (-1.02%)	⬇️
superset/views/core.py	75.48% <0.00%> (-0.04%)	⬇️
superset/utils/urls.py	100.00% <0.00%> (ø)
superset/databases/api.py	92.41% <0.00%> (ø)
superset/views/dynamic_plugins.py	100.00% <0.00%> (ø)
superset/databases/commands/create.py	92.15% <0.00%> (ø)
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6bd1e...84d4a88. Read the comment docs.

[suddjian]

/testenv up

[github-actions]

@suddjian Ephemeral environment spinning up at http://54.184.249.23:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[villebro]

Thanks for the fix!

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.