feat(native-filters): add markers and number formatter to range filter #14981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
changed the title
villebro
changed the title
villebro
commented
Jun 4, 2021
Comment on lines
-67
to
-72
| useEffect(() => { | ||
| handleAfterChange(defaultValue ?? [min, max]); | ||
| // I think after Config Modal update some filter it re-creates default value for all other filters | ||
| // so we can process it like this `JSON.stringify` or start to use `Immer` | ||
| }, [JSON.stringify(defaultValue)]); | ||
|
|
There was a problem hiding this comment.
defaultValue is now converted into filterState by the application, hence it doesn't need to be handled here
Codecov Report
@@ Coverage Diff @@
## master #14981 +/- ##
==========================================
+ Coverage 77.53% 77.60% +0.06%
==========================================
Files 965 965
Lines 49504 49530 +26
Branches 6259 6267 +8
==========================================
+ Hits 38384 38438 +54
+ Misses 10920 10891 -29
- Partials 200 201 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@kgabryje Ephemeral environment spinning up at http://34.210.133.131:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
junlincc
added
the
dashboard:native-filters
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jun 6, 2021
* upstream/master: (68 commits) fix typos (apache#14950) docs: fix custom oauth config (apache#14997) fix: apply template_params on external_metadata (apache#14996) fix: toggle fullscreen on the dashboard (apache#14979) feat(native-filters): add markers and number formatter + simple tests (apache#14981) fix(native-filters): Fix "undefined" error after editing a filter (apache#14984) fix(native-filters): remove implied fetch predicate (apache#14982) fix(native-filters): update cascaded filter state on change (apache#14980) fix(filter box): replace freeform where clause with ilike (apache#14900) refactor: Convert TableElement.jsx component from class to functional with hooks (apache#14830) fix: renamed sqllab filters to _filters (apache#14971) feat(native-filters): apply cascading without instant filtering (apache#14966) chore: bump superset-ui to 0.17.53 (apache#14968) fix(native-filters): cascading filters not rendering in tab (apache#14964) feat: add type_generic and is_dttm to table metadata (apache#14863) additional safeguard (apache#14953) feat: Adding FORCE_SSL as feature flag in config.py (apache#14934) feat(dashboard/native-filters): Hide filters out of scope of current tab (apache#14933) fix: time parser truncate to first day of year/month (apache#14945) fix: is_temporal should overwrite is_dttm (apache#14894) ...
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Small improvements to range filter:
Also:
(both story and test cases can be expanded later)
BEFORE
range_v1.mp4
AFTER
range.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION