Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pylint enable useless suppression #15769

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jul 18, 2021

SUMMARY

Per SIP-46 we generally want to reenable disabled Pylint messages, however the useless-suppression message is disabled by default and thus needs to be explicitly enabled.

Python and Pylint evolve and by enabling the useless-suppression message we ensure that our code doesn't collect unnecessary or outdated Pylint overrides.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-46] Proposal for strict Pylint enforcement #9953
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley changed the title John bodley pylint enable useless supression chore: Pylint enable useless supression Jul 18, 2021
@john-bodley john-bodley changed the title chore: Pylint enable useless supression chore: Pylint enable useless suppression Jul 18, 2021
@john-bodley john-bodley marked this pull request as draft July 18, 2021 18:47
@john-bodley john-bodley force-pushed the john-bodley--pylint-enable-useless-supression branch from 7c1bd1c to 991ce2f Compare July 18, 2021 18:49
@john-bodley john-bodley deleted the john-bodley--pylint-enable-useless-supression branch July 18, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant