-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Modal is blinking when opening #16035
fix: Modal is blinking when opening #16035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice
Codecov Report
@@ Coverage Diff @@
## master #16035 +/- ##
==========================================
- Coverage 76.79% 76.66% -0.13%
==========================================
Files 990 995 +5
Lines 52517 52787 +270
Branches 6642 6694 +52
==========================================
+ Hits 40330 40470 +140
- Misses 11963 12092 +129
- Partials 224 225 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
Fixes the modal blinking when opening.
@rusackas @junlincc
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
screen-recording-2021-08-02-at-32827-pm_yhNJpLZS.mp4
screen-recording-2021-08-02-at-32326-pm_4LdQY3DC.mp4
TESTING INSTRUCTIONS
See the before and after videos.
ADDITIONAL INFORMATION