Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explore-v2] fix errors on table view #1675

Merged
merged 5 commits into from
Nov 29, 2016
Merged

[explore-v2] fix errors on table view #1675

merged 5 commits into from
Nov 29, 2016

Conversation

ascott
Copy link

@ascott ascott commented Nov 23, 2016

  • render table name if in table view
  • only render fave star and edit button if slice, not table
  • fix html title error when table view

screenshot 2016-11-22 23 40 24

plz review @airbnb/superset-reviewers

@ascott
Copy link
Author

ascott commented Nov 29, 2016

ping @airbnb/superset-reviewers. can i plz get some 👀 on this one?

@vera-liu
Copy link
Contributor

LGTM!

@ascott ascott force-pushed the alanna-explore-v2-table-view branch from 9cc626a to d993d51 Compare November 29, 2016 04:31
@ascott ascott merged commit 56b917a into apache:master Nov 29, 2016
@ascott ascott deleted the alanna-explore-v2-table-view branch November 29, 2016 05:04
@ascott ascott mentioned this pull request Nov 29, 2016
Closed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.14.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ascott @vera-liu @mistercrunch