fix(Dashboard): Copy dashboard with duplicating charts 500 error

[geido]

SUMMARY

Fixes an issue introduced by PR #17570 that was causing a 500 error in the backend when copying a dashboard with the "also copy (duplicate) charts" option.

TESTING INSTRUCTIONS

1. Open a Dashboard
2. Save the dashboard as a new one and tick "also copy (duplicate) charts"
3. Observe the behavior

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[rusackas]

Kicking myself now... I looked at that line, and wondered about it, but I was trying not to rock the boat.

[rusackas]

Thanks for the quick turnaround fix.

[codecov]

Codecov Report

Merging #17707 (b4775cc) into master (12bd1fc) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #17707      +/-   ##
==========================================
- Coverage   67.98%   67.94%   -0.04%     
==========================================
  Files        1653     1653              
  Lines       66294    66375      +81     
  Branches     7107     7120      +13     
==========================================
+ Hits        45067    45097      +30     
- Misses      19338    19381      +43     
- Partials     1889     1897       +8     

Flag	Coverage Δ
javascript	56.25% <100.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...t-frontend/src/dashboard/actions/dashboardState.js	35.79% <100.00%> (+0.45%)	⬆️
...nd/src/explore/components/DataTablesPane/index.tsx	76.92% <0.00%> (-0.75%)	⬇️
...nd/plugins/plugin-chart-table/src/controlPanel.tsx	21.34% <0.00%> (-0.50%)	⬇️
...et-ui-chart-controls/src/shared-controls/index.tsx	38.53% <0.00%> (-0.36%)	⬇️
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx	67.15% <0.00%> (-0.26%)	⬇️
superset-frontend/src/components/Select/Select.tsx	86.33% <0.00%> (ø)
...uperset-frontend/src/utils/getClientErrorObject.ts	71.87% <0.00%> (ø)
...src/dashboard/components/PropertiesModal/index.jsx
...src/dashboard/components/PropertiesModal/index.tsx	66.87% <0.00%> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12bd1fc...b4775cc. Read the comment docs.