Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove crud.less from Datasource #19438

Merged
merged 4 commits into from
Apr 7, 2022
Merged

chore: Remove crud.less from Datasource #19438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1fffec
Remove crud less
geido Mar 30, 2022
04a9465
Remove unused classname
geido Mar 30, 2022
90f5f3d
Remove unused import
geido Apr 1, 2022
7525f00
Add theme top level
geido Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions superset-frontend/src/components/Datasource/CollectionTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import Button from 'src/components/Button';
import Icons from 'src/components/Icons';
import Fieldset from './Fieldset';
import { recurseReactClone } from './utils';
import './crud.less';

interface CRUDCollectionProps {
allowAddItem?: boolean;
Expand Down Expand Up @@ -102,9 +101,28 @@ const CrudTableWrapper = styled.div<{ stickyHeader?: boolean }>`
min
}
`}
th span {
vertical-align: ${({ theme }) => theme.gridUnit * -2}px;
}
${({ theme }) => `
th span {
vertical-align: ${theme.gridUnit * -2}px;
}
.text-right {
text-align: right;
}
.empty-collection {
padding: ${theme.gridUnit * 2 + 2}px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you removed the .control-label and .frame classes. It was intended?

Copy link
Member Author

@geido geido Apr 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-s-molina yes I checked and those two are unused. Did you find otherwise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I just wanted to confirm that it was removed intentionally.

}
.tiny-cell {
width: ${theme.gridUnit + 1}px;
}
i.fa-caret-down,
i.fa-caret-up {
width: ${theme.gridUnit + 1}px;
}
td.expanded {
border-top: 0;
padding: 0;
}
`}
`;

const CrudButtonWrapper = styled.div`
Expand Down
1 change: 0 additions & 1 deletion superset-frontend/src/components/Datasource/Field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import React, { useCallback } from 'react';
import { css, SupersetTheme } from '@superset-ui/core';
import { Tooltip } from 'src/components/Tooltip';
import { FormItem, FormLabel } from 'src/components/Form';
import './crud.less';

const formItemInlineCss = css`
.ant-form-item-control-input-content {
Expand Down
54 changes: 0 additions & 54 deletions superset-frontend/src/components/Datasource/crud.less
View file
Open in desktop

This file was deleted.