-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(schedule-query): getUISchema function called in SchemaForm component #20256
Conversation
Superset - Release and Improvements (23-03-2022)
Superset - Release and Improvements (28-03-2022)
Superset - Release and Improvements (04-04-2022)
Superset - Release and Improvements (07-04-2022)
Superset - Release and Improvements (11-04-2022)
Superset - Release and Improvements (19-04-2022)
Superset - Release and Improvements (27-04-2022)
Superset - Release and Improvements (06-05-2022)
Superset - Release and Improvements (12-05-2022)
Revert "Superset - Release and Improvements (12-05-2022)"
Superset - Release and Improvements (Conflicts)
This reverts commit 6d18661.
Revert "Revert "Superset - Release and Improvements (12-05-2022)""
Sync with Master - Superset
Superset - Release and Improvements (23-05-2022)
feat: release and improvements (30-05-2022)
Codecov Report
@@ Coverage Diff @@
## master #20256 +/- ##
==========================================
+ Coverage 66.47% 66.79% +0.32%
==========================================
Files 1727 1754 +27
Lines 64724 65562 +838
Branches 6822 6933 +111
==========================================
+ Hits 43024 43794 +770
- Misses 19969 20014 +45
- Partials 1731 1754 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@RahulRaj97 thanks for this fix. I started looking into this, and I noticed the following:
|
@villebro Thanks for reviewing the PR and clarifying the flags too. I was having the same issue while working on this and adding the |
…ent (apache#20256) * Revert "Superset - Release and Improvements (12-05-2022)" * merging conflic changes * Revert "Revert "Superset - Release and Improvements (12-05-2022)"" This reverts commit 6d18661. * fixed breaking changes * sync with master * fixed breaking flows * fixed getUISchema function call * added default placeholder and updated docs * fixed format and comments * changed flag to configuration * fix: indentation of SCHEDULED_QUERIES dict * fix: changed intendation for SCHEDULED_QUERIES * fix: updated docs for SCHEDULED_QUERIES * fix: replaced button to menu item for SCHEDULED_QUERIES * fix: updated docs for SCHEDULED_QUERIES * fix: trailing whitespace
SUMMARY
Fixed getUISchema function call in ScheduleQueryButton Component
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Configure SCHEDULED_QUERIES in config.py and press the Schedule button in Sqllab
ADDITIONAL INFORMATION