-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting db UUID #20412
feat: allow setting db UUID #20412
Conversation
620b2d1
to
efa10b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #20412 +/- ##
===========================================
- Coverage 66.63% 54.94% -11.70%
===========================================
Files 1738 1739 +1
Lines 65078 65136 +58
Branches 6885 6897 +12
===========================================
- Hits 43367 35788 -7579
- Misses 19963 27595 +7632
- Partials 1748 1753 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@betodealmeida does this need a migration or is it just an in-memory sqlalchemy construct? |
No migration needed, we're just changing the payload schema to allow an optional UUID. |
* WIP * feat: allow passing UUID when creating a DB * Test * Fix field
SUMMARY
Allow client to specify an UUID when creating a database.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
I added a unit test. I also refactored some logic into a
full_api_access
fixture that helps write integration tests.ADDITIONAL INFORMATION