fix: invalid metric should raise an exception #20882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20882 +/- ##
===========================================
- Coverage 66.25% 54.78% -11.48%
===========================================
Files 1758 1758
Lines 67048 67049 +1
Branches 7118 7118
===========================================
- Hits 44423 36730 -7693
- Misses 20808 28502 +7694
Partials 1817 1817
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
zhaoyongjie
force-pushed
the
fix/invalid_metrics
branch
from
599e1ba to
5e90682
Compare
zhaoyongjie
commented
Jul 27, 2022
| @@ -716,7 +716,7 @@ def test_get_data_transforms_dataframe(self): | |||
| self.assertEqual(data, expected) | |||
|
|
|||
| def test_get_data_empty_null_keys(self): | |||
| form_data = {"groupby": [], "metrics": ["", None]} | |||
There was a problem hiding this comment.
The metric must be a string or AdhocMetric.
zhaoyongjie
commented
Jul 27, 2022
| @@ -43,5 +43,5 @@ | |||
| "granularity_sqla": null, | |||
| "autozoom": true, | |||
| "url_params": {}, | |||
| "size": 100 | |||
| "size": "100" | |||
There was a problem hiding this comment.
the metric must be string
zhaoyongjie
commented
Jul 27, 2022
| @@ -45,5 +45,5 @@ | |||
| "granularity_sqla": null, | |||
| "autozoom": true, | |||
| "url_params": {}, | |||
| "size": 100 | |||
| "size": "100" | |||
There was a problem hiding this comment.
the metric must be string
zhaoyongjie
commented
Jul 27, 2022
Comment on lines
-64
to
+66
| class Query(Model, ExtraJSONMixin, ExploreMixin): # pylint: disable=abstract-method | ||
| class Query( | ||
| Model, ExtraJSONMixin, ExploreMixin | ||
| ): # pylint: disable=abstract-method,too-many-public-methods |
There was a problem hiding this comment.
bycatch: CI was failed by pylint error.
zhaoyongjie
requested review from
betodealmeida,
rusackas,
ktmud and
john-bodley
ktmud
approved these changes
Jul 27, 2022
| } | ||
| self.assertEqual(data, expected) | ||
|
|
||
| form_data = {"groupby": [], "metrics": [None]} |
There was a problem hiding this comment.
Should we add a test case where metric is a dict, too?
There was a problem hiding this comment.
the more unit test at here. I added some invalid metric case as well.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In some
unknown cases(may be database migration?) the ad-hoc metric may be missingexpressionTypefield, then an exception should be raised to let the user handle the incorrect metrics.the original issue was reported from shortcut.
Just judging from this error, the first
metricis not ahashabletype. e.g.TESTING INSTRUCTIONS
before fix
birth_nameas datasource,tableas vizslicestable and find out the newest record.paramscolumn and remove"expressionType":"SQL",in it.
7. go to `/api/v1/dashboard/{$DashboardID}}/datasets` will look at the error, responded status code is 500after fix
/api/v1/dashboard/{$DashboardID}}/datasetswill look at the error, the status code is 400, and error message will point out specific errors and failed the metric.ADDITIONAL INFORMATION