-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): support different replicaCount #20883
feat(helm): support different replicaCount #20883
Conversation
This reverts commit 6ab95a7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
@@ -28,7 +28,11 @@ metadata: | |||
{{ toYaml .Values.supersetWorker.deploymentAnnotations | nindent 4 }} | |||
{{- end }} | |||
spec: | |||
{{- if .Values.supersetWorker.replicaCount }} | |||
replicas: {{ .Values.supersetWorker.replicaCount }} | |||
{{- else }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make a new value under supersetWorker
and use it here (default of the current replicaCount
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so I did
- remove
replicaCount
in the values, in the schema, and in the array of required values - add
supersetNode.replicaCount
andsupersetWorker.replicaCount
in the values, in the schema, and in the array of required values - edit the "Running on Kubernetes" doc
- bump version to 0.7.0
@@ -28,7 +28,11 @@ metadata: | |||
{{ toYaml .Values.supersetNode.deploymentAnnotations | nindent 4 }} | |||
{{- end }} | |||
spec: | |||
{{- if .Values.supersetNode.replicaCount }} | |||
replicas: {{ .Values.supersetNode.replicaCount }} | |||
{{- else }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above
SUMMARY
We want to configure a different replicaCount for
supersetNode
andsupersetWorker
deployments, as they do not undergo the same load.The
replicaCount
should be configurable on a per component level instead of globally for the whole chart.TESTING INSTRUCTIONS
Templating can be verified manually with
helm template
helm lint
helm3 template superset-release .
ADDITIONAL INFORMATION