-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make a new entrypoint for deprecated postgres dialect #20895
fix: make a new entrypoint for deprecated postgres dialect #20895
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20895 +/- ##
==========================================
+ Coverage 66.27% 66.28% +0.01%
==========================================
Files 1758 1758
Lines 67072 67039 -33
Branches 7122 7116 -6
==========================================
- Hits 44453 44440 -13
+ Misses 20800 20769 -31
- Partials 1819 1830 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
@betodealmeida I tested this locally and it |
Oh, that's weird... they should both pick them up. |
0e25a70
to
9fb0263
Compare
9fb0263
to
6ca898b
Compare
@betodealmeida and I worked through this and found that |
Co-authored-by: Beto Dealmeida <[email protected]>
SUMMARY
Sqlalchemy 1.4 deprecated the
postgres
dialect and any existing Sqlalchemy URI strings that usepostgres
as opposed to the currentpostgresql
will not work. This PR creates a new entry point that will map the old postgres dialect to the current postgresql one.TESTING INSTRUCTIONS
ADDITIONAL INFORMATION