fix: Columns not passing properly from SQL Lab to Explore #20975
Conversation
| @@ -151,6 +151,7 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({ | |||
| openWindow = true, | |||
| formData = {}, | |||
| }) => { | |||
| console.log('FINDME SaveDatasetModal', datasource); | |||
There was a problem hiding this comment.
This was just debugging, it wasn't ready for review yet. I pushed up a "clean up" commit here.
| ...qe, | ||
| columns: this.props.latestQuery?.results?.columns || [], | ||
| }); | ||
| console.log('findme SqlEditor', qe, queryWithColumns()); |
There was a problem hiding this comment.
This was just debugging, it wasn't ready for review yet. I pushed up a "clean up" commit here.
| @@ -166,6 +167,7 @@ export default function SaveQuery({ | |||
| </Form> | |||
| ); | |||
|
|
|||
| console.log('FINDME SaveQuery', query, queryPayload()); | |||
There was a problem hiding this comment.
This was just debugging, it wasn't ready for review yet. I pushed up a "clean up" commit here.
Codecov Report
@@ Coverage Diff @@
## master #20975 +/- ##
==========================================
- Coverage 66.38% 66.18% -0.20%
==========================================
Files 1766 1767 +1
Lines 67225 67246 +21
Branches 7137 7142 +5
==========================================
- Hits 44625 44509 -116
- Misses 20774 20909 +135
- Partials 1826 1828 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
/testenv up |
|
@hughhhh Ephemeral environment spinning up at http://34.220.152.102:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
* debugging columns * Clean up code * Fix test (cherry picked from commit d42cf4e)
mistercrunch
added
🏷️ bot
SUMMARY
Columns were not passing properly from SQL Lab to Explore. This PR fixes that by passing the columns from
latestQuery.results.columnsinto SaveQuery from SqlEditor.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
vbutton on the save button and click Save DatasetADDITIONAL INFORMATION