-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor ResultSet to functional component #21186
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a4412f8
chore: refactor ResultSet to functional component
EugeneTorap 37d68c6
Fix bugs
EugeneTorap 7d21ad4
Refactoring
EugeneTorap 22fd203
Refactoring
EugeneTorap 8998d04
Refactoring styles
EugeneTorap 6058205
Refactoring actions
EugeneTorap 4fa4bad
Refactoring actions
EugeneTorap d9ba9fc
Refactoring tests
EugeneTorap e248931
Refactoring tests
EugeneTorap 8c3408b
Refactoring tests
EugeneTorap 19acdc2
Refactoring tests
EugeneTorap 3fd5cbb
Refactoring tests
EugeneTorap 75c9671
Refactoring tests
EugeneTorap e1f240f
Refactoring
EugeneTorap e32e0db
Fix tests
EugeneTorap 63bec8f
Refactoring
EugeneTorap a5e6079
Fix act errors
EugeneTorap cf55134
Merge branch 'master' into refactor/ResultSet-to-fc
EugeneTorap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
219 changes: 0 additions & 219 deletions
219
superset-frontend/src/SqlLab/components/ResultSet/ResultSet.test.jsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define
any
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently
any
is ok becauseactions/sqlLab.js
is not typedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to type
useDispatch
though - in most places we just doconst dispatch = useDispatch()