-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sqllab): Make LeftBar width resizable #21300
feat(sqllab): Make LeftBar width resizable #21300
Conversation
cc: @nytai for visibility |
969a1fd
to
dfa7285
Compare
Codecov Report
@@ Coverage Diff @@
## master #21300 +/- ##
=======================================
Coverage 66.43% 66.43%
=======================================
Files 1788 1788
Lines 68268 68268
Branches 7269 7269
=======================================
Hits 45352 45352
Misses 21043 21043
Partials 1873 1873
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Like it 👍 |
SUMMARY
following feedback from #21280
Since the #21280 can cover too much space by the left bar panel, this commit makes the sidebar width fixed and collapsed the overflowing items as well.
As #20778 introduces the resizable menu on dashboard, this commit refactors the resizable component shareable and then introduces the resizable feature to sqllab left bar so user can expend the width to check the full text on demand.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
sqllab-sidebar--after.mov
resizable--sqllab-left-bar.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
cc: @EugeneTorap @ktmud