feat: Making bar graphs in Table viz from fixed-size divs instead of calculated gradients #21482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
changed the title
Codecov Report
@@ Coverage Diff @@
## master #21482 +/- ##
==========================================
+ Coverage 66.66% 66.74% +0.07%
==========================================
Files 1791 1801 +10
Lines 68498 69252 +754
Branches 7286 7554 +268
==========================================
+ Hits 45666 46221 +555
- Misses 20962 21121 +159
- Partials 1870 1910 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/testenv up |
|
@geido Ephemeral environment spinning up at http://54.203.213.47:8080. Credentials are |
michael-s-molina
approved these changes
Sep 16, 2022
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
Outdated
Show resolved
Hide resolved
ktmud
approved these changes
Sep 20, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
mayurnewase
added a commit
to mayurnewase/incubator-superset
that referenced
this pull request
Sep 22, 2022
…tead of calculated gradients (apache#21482)" This reverts commit 135909f.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Table viz allows users to have little histogram/bar chart cells which can be gray, red when negative, or colorized via conditional formatting. Previously, these were implemented as the CSS background of the table cells, and a gradient was used to draw the bars, with gradient stops to set bar widths. This was problematic as people could not customized these with CSS, and it was also a potentially difficult to understand implementation from a maintenance standpoint.
In this revised approach, divs are conditionally added to table cells to act as these bars, and they're positioned behind the text content. They use a few small functions to calculate width, offset, and color for their display. They're also rendered with a
cell-barclass and (when applicable) anegativeorpositiveclass to indicate if they're positive or negative, for further customization options.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visual changes here - just representing what was changed. But, this is the "after" FWIW.
TESTING INSTRUCTIONS
Test example tables, and throw different formatting options at the table. I think this covers all the use cases, but there's always a chance I missed something!
ADDITIONAL INFORMATION