fix(sqllab): SqlEditorLeftBar listening to database changes #21628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We stopped listening to database prop changes at some point to only take into account the initial component render. That however, caused the component to always work with the initial database passed as prop and never take into account new user selections. Which you might evidence for example with empty table dropdown after changing DB.
We're bringing that feature back with this fix. Also we're using the right props in our tests and adding a new one to consider the re-renders with new database.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Go to sql lab and do a query on your default data base
In the same query tab, switch databases
Select your table
Try to select a table
ADDITIONAL INFORMATION