Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Horizontal filter bar states #22064

Merged
merged 24 commits into from
Nov 18, 2022
Merged

Conversation

geido
Copy link
Member

@geido geido commented Nov 8, 2022

SUMMARY

This PR implements the horizontal container of the FilterBar and splits the component into two, Vertical and Horizontal.

AFTER

Supported.Charts.Dashboard.mp4

TESTING INSTRUCTIONS

  1. Set HORIZONTAL_FILTER_BAR feature flag to True
  2. Go to a Dashboard and open the left sidebar
  3. Click on the gear icon to change the FilterBar orientation to horizontal

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: HORIZONTAL_FILTER_BAR
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #22064 (e9eb919) into master (95b4c7b) will increase coverage by 0.86%.
The diff coverage is 78.43%.

@@            Coverage Diff             @@
##           master   #22064      +/-   ##
==========================================
+ Coverage   67.09%   67.96%   +0.86%     
==========================================
  Files        1827     1830       +3     
  Lines       69875    72349    +2474     
  Branches     7548     7562      +14     
==========================================
+ Hits        46884    49173    +2289     
- Misses      21035    21215     +180     
- Partials     1956     1961       +5     
Flag Coverage Δ
hive 53.39% <100.00%> (+0.54%) ⬆️
javascript 53.74% <78.21%> (+0.01%) ⬆️
mysql 79.33% <100.00%> (+0.92%) ⬆️
postgres 79.38% <100.00%> (+0.91%) ⬆️
presto 53.29% <100.00%> (+0.55%) ⬆️
python 82.33% <100.00%> (+0.75%) ⬆️
sqlite 77.79% <100.00%> (+0.86%) ⬆️
unit 51.23% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/components/DropdownSelectableIcon/index.tsx 100.00% <ø> (ø)
superset-frontend/src/dashboard/actions/hydrate.js 1.78% <ø> (ø)
...ilters/FilterBar/FilterConfigurationLink/index.tsx 100.00% <ø> (ø)
...Filters/FilterBar/FilterControls/FilterControl.tsx 29.03% <ø> (ø)
...nativeFilters/FilterBar/FilterSets/EditSection.tsx 75.86% <ø> (ø)
...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx 92.85% <ø> (ø)
...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx 89.65% <ø> (ø)
...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx 90.00% <ø> (ø)
...nents/nativeFilters/FilterBar/FilterSets/index.tsx 37.66% <ø> (ø)
...t-frontend/src/dashboard/reducers/dashboardInfo.js 80.00% <ø> (ø)
... and 26 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@geido geido marked this pull request as ready for review November 9, 2022 15:19
@geido geido added risk:refactor High risk as it involves large refactoring work need:qa-review Requires QA review labels Nov 9, 2022
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @geido. I still have some files to review but I'll leave some comments already in case you want to work on them. Awesome work!

Copy link
Member

@codyml codyml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works! Left some comments.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Thanks for all the hard work and for addressing the comments @geido! I suggest waiting for @jinghua-qa's approval before merging it.

…rBar/HorizontalFilterBar.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
geido and others added 8 commits November 15, 2022 15:18
…rBar/HorizontalFilterBar.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@geido
Copy link
Member Author

geido commented Nov 16, 2022

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://18.236.65.179:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@jinghua-qa
Copy link
Member

Regression test LGTM

@jinghua-qa
Copy link
Member

/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true

@github-actions
Copy link
Contributor

@jinghua-qa Ephemeral environment spinning up at http://54.185.42.234:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido merged commit 25114a7 into master Nov 18, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the feat/horizontal-filterbar-states branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review risk:refactor High risk as it involves large refactoring work size/XXL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants