-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Horizontal filter bar states #22064
Conversation
…/horizontal-filterbar-states
Codecov Report
@@ Coverage Diff @@
## master #22064 +/- ##
==========================================
+ Coverage 67.09% 67.96% +0.86%
==========================================
Files 1827 1830 +3
Lines 69875 72349 +2474
Branches 7548 7562 +14
==========================================
+ Hits 46884 49173 +2289
- Misses 21035 21215 +180
- Partials 1956 1961 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @geido. I still have some files to review but I'll leave some comments already in case you want to work on them. Awesome work!
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Horizontal.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/HorizontalFilterBar.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/utils.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it works! Left some comments.
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx
Outdated
Show resolved
Hide resolved
...-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarLocationSelect/index.tsx
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Horizontal.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Horizontal.tsx
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
Show resolved
Hide resolved
…rBar/Header/index.tsx Co-authored-by: Michael S. Molina <[email protected]>
…rBar/Horizontal.tsx Co-authored-by: Michael S. Molina <[email protected]>
…rBar/Vertical.tsx Co-authored-by: Michael S. Molina <[email protected]>
…/horizontal-filterbar-states
…/apache/superset into feat/horizontal-filterbar-states
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Thanks for all the hard work and for addressing the comments @geido! I suggest waiting for @jinghua-qa's approval before merging it.
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/HorizontalFilterBar.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/HorizontalFilterBar.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/HorizontalFilterBar.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/HorizontalFilterBar.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/HorizontalFilterBar.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/HorizontalFilterBar.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/HorizontalFilterBar.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/HorizontalFilterBar.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/HorizontalFilterBar.test.tsx
Outdated
Show resolved
Hide resolved
…rBar/HorizontalFilterBar.test.tsx Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx Co-authored-by: Michael S. Molina <[email protected]>
…rBar/HorizontalFilterBar.test.tsx Co-authored-by: Michael S. Molina <[email protected]>
/testenv up |
@geido Ephemeral environment spinning up at http://18.236.65.179:8080. Credentials are |
Regression test LGTM |
/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true |
@jinghua-qa Ephemeral environment spinning up at http://54.185.42.234:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR implements the horizontal container of the FilterBar and splits the component into two, Vertical and Horizontal.
AFTER
Supported.Charts.Dashboard.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION