-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Programmatically open "more filters" dropdown in Horizontal Filter Bar #22276
Conversation
…/hfb-open-more-filters
Codecov Report
@@ Coverage Diff @@
## master #22276 +/- ##
===========================================
+ Coverage 55.69% 66.92% +11.22%
===========================================
Files 1846 1847 +1
Lines 70302 70602 +300
Branches 7689 7819 +130
===========================================
+ Hits 39157 47247 +8090
+ Misses 29151 21343 -7808
- Partials 1994 2012 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/utils.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/util/useFilterFocusHighlightStyles.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/util/useFilterFocusHighlightStyles.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/util/useFilterFocusHighlightStyles.ts
Outdated
Show resolved
Hide resolved
….jsx Co-authored-by: Michael S. Molina <[email protected]>
…yles.ts Co-authored-by: Michael S. Molina <[email protected]>
…yles.ts Co-authored-by: Michael S. Molina <[email protected]>
…yles.ts Co-authored-by: Michael S. Molina <[email protected]>
…e/superset into feat/hfb-open-more-filters
…/hfb-open-more-filters
…/hfb-open-more-filters
/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true |
@kgabryje Container image not yet published for this PR. Please try again when build is complete. |
@kgabryje Ephemeral environment creation failed. Please check the Actions logs for details. |
…/hfb-open-more-filters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that @kgabryje! I am having a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
SUMMARY
This PR adds the ability to open the "more filters" dropdown in the horizontal filter bar while refactoring the code to better differentiate between focus and hover actions on native filters.
AFTER
FCC.New.Coder.Survey.2018.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION