fix(dashboard): Add runtime safety checks and improved tests #22457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add runtime safety checks and improved tests to recursivelyDeleteChildren and findParentId functions
There have been cases where a dashboard ends up with an invalid componentId causing code in workspace to fail removal of a tab. The root cause of where the errant id comes from is still under investigation. This PR adds runtime safety checks to code that was fail when a bad ID existed to treat the symptom and make the application more fault tolerant.
PR adds test to simulate bad states passed into functions to ensure they do not throw uncaught errors.
PR also converts two files to TypeScript to make interfaces more clear.
All existing tests were left unchanged to ensure previous behavior is stable.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION