-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: schedule query option showing up #23386
fix: schedule query option showing up #23386
Conversation
86ce314
to
29ed59b
Compare
I was testing the 2.1 rc last night and I noticed the same, took me a while to figure it out. I ended up setting |
29ed59b
to
e319da1
Compare
Codecov Report
@@ Coverage Diff @@
## master #23386 +/- ##
=======================================
Coverage 67.63% 67.63%
=======================================
Files 1908 1908
Lines 73716 73729 +13
Branches 7989 7989
=======================================
+ Hits 49856 49867 +11
- Misses 21812 21814 +2
Partials 2048 2048
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Michael S. Molina <[email protected]>
SUMMARY
The "schedule query" option in SQL Lab is showing up even when the feature is not configured... I suspect because of this change: https://github.com/apache/superset/pull/20256/files
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION