fix(sqllab): dedupe table_schemas in active_tab #23514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Addition to #23265 fix
When SQLLAB_BACKEND_PERSISTENCE has been deactivated after activated, active_tab will be provided during localstorage persistence mode.
This causes the appending duplicated table_schemas value every time page is loaded. (This causes the increasing localStorage size)
This commit adds the dedupe logic to clean up the duplicated values.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
Before:
TESTING INSTRUCTIONS
set SQLLAB_BACKEND_PERSISTENCE on and open SqlLab
select one table to fetch the table schema info
disable SQLLAB_BACKEND_PERSISTENCE and open SqlLab
keep refresh the page and then check the redux value in the local storage
ADDITIONAL INFORMATION
@michael-s-molina @ktmud