Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In #23200 I added permission checks when importing related assets. Before, users importing dashboards could create databases and datasets as a side effect of the import, even if they didn't have the appropriate permissions. The PR added some extra checks to prevent this from happening:
superset/superset/databases/commands/importers/v1/utils.py
Line 34 in 56dcf25
The change above required modifying
load-examples
to run as a user with username "admin":superset/superset/commands/importers/v1/examples.py
Line 72 in 56dcf25
But the user "admin" might not exist, or might be called differently. So this PR changes
load-examples
so that the imports happen without acurrent_user
, as before, while keeping the permission checks for other imports initiated via the UI.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION