-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support complex types and use get_columns implementation of starrrocks python client #24237
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24237 +/- ##
==========================================
+ Coverage 68.33% 68.35% +0.01%
==========================================
Files 1957 1957
Lines 75628 75609 -19
Branches 8225 8225
==========================================
Hits 51680 51680
+ Misses 21835 21816 -19
Partials 2113 2113
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looks reasonable to me, but deferring to @john-bodley @betodealmeida and @villebro who will be better at spotting the "gotchas" than I am ;) Much appreciated! |
Thanks @miomiocat for the PR. Would you mind:
|
Done, please take a look at this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the improvements, cleanup and added tests 👍 While I kinda would prefer the transparent background on the logo, the dark text would make it illegible on dark mode if the background were to be dark, so maybe it's better like this.
SUMMARY
get_columns
from db_spec to use the dialect's implementation of starrocks own python clientBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION