-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tags): move tags from navbar to settings #24518
Conversation
/testenv up |
@hughhhh Container image not yet published for this PR. Please try again when build is complete. |
@hughhhh Ephemeral environment creation failed. Please check the Actions logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #24518 +/- ##
==========================================
- Coverage 69.07% 69.07% -0.01%
==========================================
Files 1902 1902
Lines 74024 74010 -14
Branches 8117 8117
==========================================
- Hits 51134 51121 -13
+ Misses 20779 20778 -1
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Co-authored-by: Daniel Vaz Gaspar <[email protected]>
SUMMARY
With the new designs, we are going to move tags into the right menu settings under manage. Also we going to hide all entities from the nav completely. Users will be able to see all entities by going to Tags -> clicking one of the tags see all entities page
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION