chore: Re-enable some GitHub action workflows in draft mode #24626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
requested review from
villebro,
geido,
betodealmeida,
nytai,
mistercrunch,
craig-rueda and
kgabryje
as code owners
Codecov Report
@@ Coverage Diff @@
## master #24626 +/- ##
==========================================
+ Coverage 68.97% 69.08% +0.10%
==========================================
Files 1907 1907
Lines 74153 74153
Branches 8182 8182
==========================================
+ Hits 51148 51225 +77
+ Misses 20882 20805 -77
Partials 2123 2123
Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
john-bodley
force-pushed
the
john-bodley--partial-revert-12666
branch
from
45731b3 to
80a1a50
Compare
|
@michael-s-molina per our conversation earlier today I relaxed the constraint to remove the draft checks from all the workflows. |
michael-s-molina
approved these changes
Jul 11, 2023
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a partial revert of #12666 which was likely authored when Apache's CI was under heavy load. Specifically it reenables all the workflows when a PR is in draft mode. This enables the author to iterate on fixing any issues prior to it being deemed eligible for review.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI and additionally ensured there were no references to
draftin the GitHub actions, i.e.,ADDITIONAL INFORMATION