Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Calendar Heatmap day offset #24989

Merged
merged 1 commit into from
Aug 15, 2023
Merged

fix: Calendar Heatmap day offset #24989

merged 1 commit into from
Aug 15, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR fixes a bug where the Calendar Heatmap was displaying data with an offset of one day due to timezone differences.

See wa0x6e/cal-heatmap#126

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Results panel shows December 9 but Heatmap shows December 8
Screenshot 2023-08-15 at 11 25 06

Heatmap and the Results panel match
Screenshot 2023-08-15 at 11 24 18

TESTING INSTRUCTIONS

Make sure the Heatmap matches the dates in the Results panel.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch and removed size/S labels Aug 15, 2023
villebro
villebro approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what an unexpected bug.

@michael-s-molina michael-s-molina merged commit 025e4d4 into apache:master Aug 15, 2023
michael-s-molina added a commit that referenced this pull request Aug 16, 2023
@michael-s-molina
fix: Calendar Heatmap day offset (#24989)
3ffc5b6 
(cherry picked from commit 025e4d4)
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
@GillesTo GillesTo mentioned this pull request Jun 4, 2024
Open
3 tasks
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
fix: Calendar Heatmap day offset (apache#24989)
1904c7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@justinpark justinpark Awaiting requested review from justinpark

@kgabryje kgabryje Awaiting requested review from kgabryje

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @villebro @mistercrunch