chore(sqllab): typescript for getInitialState #25047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpark
commented
Aug 21, 2023
| @@ -49,16 +50,6 @@ export interface Column { | |||
| type: string; | |||
| } | |||
|
|
|||
| export interface Table { | |||
There was a problem hiding this comment.
migrate to SqlLab/types
justinpark
commented
Aug 21, 2023
| ) { | ||
| const { sqlLab } = JSON.parse(localStorage.getItem('redux')); | ||
| const localStorageData = localStorage.getItem('redux'); | ||
| const sqlLabCacheData = localStorageData |
There was a problem hiding this comment.
Stores the parsed object here to save the additional JSON.parse operation at line 147
There was a problem hiding this comment.
Thank you for PR @justinpark. I left some first-pass comments.
| }, | ||
| messageToasts: getToastsFromPyFlashMessages( | ||
| (common || {}).flash_messages || [], | ||
| (common || {})?.flash_messages || [], |
There was a problem hiding this comment.
Suggested change
| (common || {})?.flash_messages || [], | |
| (common || {}).flash_messages || [], |
michael-s-molina
approved these changes
Aug 24, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Part 2 of SQLLab SPA migration: detail link
This commit migrates the existing getInialState helper to typescript to be compatible with SPA entrypoint with
/api/v1/sqllab/. (This commit also adjusts the existing SqlLab types and dependent types)This commit also introduces
useSqlLabInitialStateQuerywhich fetches/api/v1/sqllab/and will be used with the updated getInitialState helper in the next page component integration.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
npm run type
npm run test
ADDITIONAL INFORMATION