-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bumps Flask Caching to fix RCE vulnerability #25090
fix: Bumps Flask Caching to fix RCE vulnerability #25090
Conversation
9515953
to
affa48e
Compare
fbd29ff
to
9282677
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all the work on debugging that flaky test, really great work! 👏 Also, please add a note in the description about removing cachelib
as an explicit dependency, as it may not be obvious why that's happening.
cachelib==0.6.0 | ||
# via flask-caching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm tempted to bump this one to a more recent one, but let's do that when we bump to Flask-Caching>=2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's safer to do that when bumping Flask-Caching 👍🏼
@villebro I updated the PR description. |
…)" This reverts commit 9df1b26.
…)" This reverts commit 9df1b26.
…)" This reverts commit 9df1b26.
@michael-s-molina Flask-caching 1.11.1 does not fixes CVE-2021-33026. |
@SCH227 It looks like the CVE is still in DISPUTED state pending additional verification. Check pallets-eco/flask-caching#345 for more context. |
SUMMARY
This PR bumps Flask Caching from
1.10.1
to1.11.1
to fix CVE-2021-33026. It also removes an explicit dependency withcachelib
given that its assets are provided viaflask_caching.backends
.Fixes #25077
Here's the changelog between versions:
TESTING INSTRUCTIONS
CI should be sufficient.
ADDITIONAL INFORMATION