feat: removing renderCard from Tags/index.tsc to remove cardview from Tags ListView #25105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
changed the title
|
@fisjac thanks for the change. Would you mind adding a more descriptive PR description as well as a before and after screenshot? This would significantly help the review process. |
|
/testenv up |
|
@jinghua-qa Ephemeral environment spinning up at http://35.93.7.79:8080. Credentials are |
hughhhh
approved these changes
Aug 30, 2023
|
Ephemeral environment shutdown and build artifacts deleted. |
darwinsubramaniam
pushed a commit
to darwinsubramaniam/superset
that referenced
this pull request
Sep 7, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Tags were being displayed with an option to view as cards. This was not part of the design of the tags feature.
To remove the cards from the ListView component, I removed the renderCard prop from from the TagList component to prevent card option settings from rendering in the ListView component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION