-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Date format when importing international timestamps #25113
Merged
michael-s-molina
merged 1 commit into
apache:master
from
michael-s-molina:fix-import-date-format
Aug 30, 2023
Merged
fix: Date format when importing international timestamps #25113
michael-s-molina
merged 1 commit into
apache:master
from
michael-s-molina:fix-import-date-format
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+75
to
+78
<tr> | ||
{{ lib.render_field(form.day_first, begin_sep_label, end_sep_label, | ||
begin_sep_field, end_sep_field) }} | ||
</tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the relevant change. The rest is just formatting.
eschutho
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
john-bodley
approved these changes
Aug 29, 2023
michael-s-molina
added a commit
that referenced
this pull request
Aug 30, 2023
(cherry picked from commit 00550d7)
darwinsubramaniam
pushed a commit
to darwinsubramaniam/superset
that referenced
this pull request
Sep 7, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a problem when importing CSV data that contains international timestamps (days come before months). We use Pandas read_csv to handle this operation and this PR exposes the
dayfirst
configuration to address the issue.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: using the following CSV, we can see that the dates are not parsed correctly.
After: We provide the
Day First
configuration for international formats.TESTING INSTRUCTIONS
1 - Import the example CSV
2 - Check the Day First configuration
3 - Make sure data is imported correctly
ADDITIONAL INFORMATION