fix(sqllab): error while removing a referenced table #25114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
added
the
v3.0
michael-s-molina
pushed a commit
that referenced
this pull request
Aug 30, 2023
(cherry picked from commit 2935557)
darwinsubramaniam
pushed a commit
to darwinsubramaniam/superset
that referenced
this pull request
Sep 7, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #25111
When a table schema is already populated and synced with remote id, the autocomplete can trigger 'MERGE_TABLE' with the already referenced table. This action can overwrite the remote id by the auto-gen id.
This commit fixes this bug by skipping the overwrite the remote id. This commit also fixes the unexpected narrow gap between table control buttons due to the icon migration from font-awesome to antd icons
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after--overwrite-remote-id.mov
before--overwrite-remote-id.mov
TESTING INSTRUCTIONS
set SQLLAB_BACKEND_PERSISTENCE True
Go to SQLLAB and enable autocomplete
Select a table in the table schema selector
Type some table name which is selected above
Click the same table from the autocomplete
Remove the table by the table action button
Check the error
ADDITIONAL INFORMATION