fix(sqllab): Invalid start date

[justinpark]

SUMMARY

Fixes #24790

Since /updated_since api migrate to v1 in #22611 , the startDttm format has been changed from a number to a string.

api/v1	legacy api

Similar to #19605, it fails the conversion to a moment object. Since the Flask’s JSON serialization of decimals casts it to a string is actually correct as it preserves precision, so the frontend should expect strings.
This commit adds the extra parse logic in sqllab query sync to handle the floating value in the string format.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

https://user-images.githubusercontent.com/1392866/264449407-c2015fe7-d1ef-48b4-9c98-60de6aa27c9c.png

Before:

https://user-images.githubusercontent.com/57723564/255794908-2b4a9005-00fc-4adc-95b0-d7a8a0fdee09.png

TESTING INSTRUCTIONS

Go to SQLLab and run a query
Go to Query history and check the start date column

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

@justinpark how is there any merit to casting this to a Decimal as opposed to a Number or are these types typically not used by the Superset frontend?

[justinpark]

Good point. I also concerned about the data inaccuracy issue since this will convert all float numbers in Number(even Decimal) which can drop some digits in a long form 234020423042304302.402 vs 234020423042304300 (=Number(234020423042304302.402))

I reverted this json-bigint modification and made the extra date value conversion logic in SqlLab instead.

[john-bodley]

@justinpark I think your current implementation is safer, i.e., casting specific instances of stringified decimals to a Number as opposed to all.

[mdeshmu]

@justinpark can you please also add a date component to "Started" in SQL Lab Query History as it is really difficult to identify what date query ran on with just time displayed.

[justinpark]

@mdeshmu I added the date value in the format.

[mdeshmu]

2023-08-31 19:37:53+05:30

@justinpark thanks for adding the date. We are using the above format in the Query History Tab.
Do we wanna keep it the same here for the sake of consistency?
I am fine with either though :)

[michael-s-molina]

LGTM. Thanks for the fix @justinpark!

I like @mdeshmu suggestion to make the time format consistent with SQL -> Query History 👍🏼

[mdeshmu]

@michael-s-molina Please include this PR in 3.0. Thanks.

[justinpark]

justinpark thanks for adding the date. We are using the above format in the Query History Tab. Do we wanna keep it the same here for the sake of consistency? I am fine with either though :)

Sounds good. I changed to same format as Query History as well as from MM/DD/YYYY to L (which is like 09/04/1986 in local format, so date value comes first in eu countries)