feat(datasource): Checkbox for always filtering main dttm in datasource

[Always-prog]

SUMMARY

Fixes #22223.
There a feature in Superset that permanently adds a second time column to requests to Clickhouse, ElasticSearch, Kusto. But there is an problem with it, as many people think it's a bug :).

How about adding a checkbox for feature time secondary column to the dataset? i think it would be better than hardcoding it for all database connections (Clickhouse, elasticsearch, Kusto). It would also allow the ability to add a second time column to other databases. This PR doing it!

SCREENSHOTS

Here is how it looks for user

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: ES dataset will auto add default datetime column to sql though chart already has another datetime column as time column #22223
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[Always-prog]

@eschutho Hi! Should that checkbox be in the database connection? Or it need to be in the dataset settings.

[eschutho]

@Always-prog this looks like good to me here in the dataset editor, but it wouldn't work for all databases, is that right?
cc @yousoph for another opinion.

[Always-prog]

@eschutho Currently this feature will works for all databases if checkbox is checked, and I think it's ok.

[yousoph]

Suggestion on the text:

• Use header text "Secondary Time Column"
• Checkbox text: When secondary time columns are filtered, apply the same filter to the default datetime column

Should we call the field "Secondary Time Column" or "Secondary Datetime Column" to match "Default Datetime" in the datasets?

[betodealmeida]

This is awesome, I think it's a better approach. I left a few comments, and also, can you add a unit test showing the query that is generated when the column is on vs. off?

[Always-prog]

@betodealmeida Done, I added unit test and fixed name of the checkbox.

[justinpark]

@Always-prog This commit looks more like a feature. Could you change the title from fix to feat?

[Always-prog]

@justinpark Done

[Always-prog]

@eschutho @betodealmeida Hi!
Can I get merge?

[Always-prog]

@eschutho Hi! If PR is ok, can I get merge :P?

[betodealmeida]

This is awesome!