Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(misc): Spelling #25456

Merged
merged 44 commits into from
Sep 29, 2023
Merged

chore(misc): Spelling #25456

merged 44 commits into from
Sep 29, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 28, 2023

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

jsoref added 30 commits September 28, 2023 19:22
@jsoref
spelling: assignees
977d189 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: bootstrapping
3ba801b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: comparison
0191ef0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: compatibility
5c987e5 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: components
6ac1335 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: config
1c24e4d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: contributing
cb50153 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: customization
2669f87 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: dashboard
f5270d1 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: database
97101eb 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: debian
da5f546 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: disappeared
833d53d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: donut
3010ea6 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: editing
7efc7c9 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: environment
6a1da64 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: filterable
446457e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: filters
0c6b01c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: flushing
54bcce4 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: frontend
df52b74 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: gauge
997ab89 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: github
b89235c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: hiding
5fa9bf6 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: intended
e71de65 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: into
20de818 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: javascript
d425ff1 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: malformed
1f06532 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: multi
4a37ba1 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: multiple
18649a7 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: neither
78af383 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: nonexistent
113c103 
Signed-off-by: Josh Soref <[email protected]>
jsoref added 11 commits September 28, 2023 19:22
@jsoref
spelling: respective
2f35ed0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: retrieval
fcad209 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: see
db486af 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: separate
687ac2b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: starrocks
3f13b66 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: storybook
93ac4d9 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: truncated
beb51f6 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: typescript
c3a3693 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: unnecessary
3ad5d7e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: when
e3f10a3 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
reword neither/nor
580f1ae 
Signed-off-by: Josh Soref <[email protected]>
jsoref
jsoref commented Sep 28, 2023
View reviewed changes
.github/ISSUE_TEMPLATE/sip.md
asignees: "apache/superset-committers"
assignees: "apache/superset-committers"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably pretty important

.github/CODEOWNERS
# Notify PMC members of changes to Github Actions
# Notify PMC members of changes to GitHub Actions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brand

CHANGELOG.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I avoided correcting commit messages about typos...

CONTRIBUTING.md
| `#bug` | Bug report | Bug fix |
| `#code-quality` | Describe problem with code, architecture or productivity | Refactor, tests, tooling |
| `#feature` | New feature request | New feature implementation |
| `#refine` | Propose improvement such as adjusting padding or refining UI style, excluding new features, bug fixes, and refactoring. | Implementation of improvement such as adjusting padding or refining UI style, excluding new features, bug fixes, and refactoring. |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nontrivial reword because the original was a bit of a mess.

Fwiw, the spell-check-this rule is not/nor => neither/nor https://github.com/check-spelling/spell-check-this/blob/b968ca32e0e5961a85c7fe3e9431f81553c3f434/.github/actions/spelling/line_forbidden.patterns#L107-L108, but that didn't actually work here.

scripts/generate_frontend_ts_tasklist.js
const hasTypescriptFiles =
const hasTypeScriptFiles =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brand

@mistercrunch mistercrunch merged commit 3e0c70d into apache:master Sep 29, 2023
@jsoref jsoref deleted the spelling-misc branch September 29, 2023 17:22
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@jsoref
chore(misc): Spelling (apache#25456)
e5d2e3d 
Signed-off-by: Josh Soref <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@jsoref
chore(misc): Spelling (apache#25456)
481a3e5 
Signed-off-by: Josh Soref <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoref @mistercrunch