build: Parallelize the CI image builds #25564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaces custom script to set tags with docker/metadata-action GitHub Action
- replaces custom script to sequentially build images with docker/build-push-action GitHub Action
- moves docker-release.yml logic into docker.yml by utilizing docker/metadata-action 'tags: type=pep440,pattern={{version}}'
- removes docker buildx local cache usage as every build runs on its own job hence on different machines (docker buildx registry cache will be a follow-up PR)
| @@ -21,33 +24,253 @@ jobs: | |||
| echo "has-secrets=1" >> "$GITHUB_OUTPUT" | |||
| echo "has secrets!" | |||
| else | |||
| echo "has-secrets=0" >> "$GITHUB_OUTPUT" | |||
| echo "no secrets!" | |||
| fi | |||
There was a problem hiding this comment.
This does not work as expected. The check if: needs.config.outputs.has-secrets returns true in both cases.
Either check for if: needs.config.outputs.has-secrets == 1 or don't set has-secrets when there are no secrets. I went with the latter.
9 tasks
sebastianliebscher
changed the title
sebastianliebscher
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
john-bodley and
kgabryje
as code owners
9 tasks
|
Any updates here? Looks like there's conflicts :) |
|
I pull this, rebased and reopened here #26697 |
|
Closing this since #26698 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR replaces the custom script
docker_build_push.shthat runs the docker builds sequentially with GitHub action jobs running in parallel.docker/metadata-actionGitHub Actiondocker/build-push-actionGitHub Actiondocker/metadata-actiontags: type=pep440,pattern={{version}}No functionality changed, except:
TESTING INSTRUCTIONS
Use case: PR from fork (can be verified by the successful jobs from this PR)
Use case: PR from Superset repo
Use case: commit to master
Use case: release
ADDITIONAL INFORMATION