Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding 'no-experimental-fetch' node option by default #25628

Merged
merged 4 commits into from
Dec 12, 2023
+92 −76
Merged

chore: adding 'no-experimental-fetch' node option by default #25628

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9201ecf
chore: adding 'no-experimental-fetch' node option on scripts, removin…
rusackas Oct 12, 2023
fea9aa3
unding the NODE_OPTIONS change, installing source-map explicitly
rusackas Oct 13, 2023
567d9b1
Merge branch 'master' into no-experimental-fetch
rusackas Nov 20, 2023
27993f6
moving from prod to dev dependency.
rusackas Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions CONTRIBUTING.md
View file
Original file line number Diff line number Diff line change
@@ -598,18 +598,6 @@ There are three types of assets you can build:
2. `npm run dev-server`: local development assets, with sourcemaps and hot refresh support
3. `npm run build-instrumented`: instrumented application code for collecting code coverage from Cypress tests

If this type of error comes while building assets(i.e using above commands):

```bash
Error: You must provide the URL of lib/mappings.wasm by calling SourceMapConsumer.initialize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though i didn't add these docs but I feel calling SourceMapConsumer.initialize would still be needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon messing with it, it seems like you shouldn't have to call the initialize method when using React... and that merely installing the source-map npm module fixes this.

I did unset NODE_OPTIONS to set my machine back to "stock" and all of the webpack build modes seem to work fine now.

```

Then put this:

```bash
export NODE_OPTIONS=--no-experimental-fetch
```

If while using the above commands you encounter an error related to the limit of file watchers:

```bash
@@ -618,7 +606,6 @@ Error: ENOSPC: System limit for number of file watchers reached
The error is thrown because the number of files monitored by the system has reached the limit.
You can address this this error by increasing the number of inotify watchers.


The current value of max watches can be checked with:
```bash
cat /proc/sys/fs/inotify/max_user_watches
@@ -635,6 +622,7 @@ To confirm that the change succeeded, run the following command to load the upda
```bash
sudo sysctl -p
```

#### Webpack dev server

The dev server by default starts at `http://localhost:9000` and proxies the backend requests to `http://localhost:8088`.
153 changes: 90 additions & 63 deletions superset-frontend/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions superset-frontend/package.json
View file
Original file line number Diff line number Diff line change
@@ -332,6 +332,7 @@
"react-test-renderer": "^16.9.0",
"redux-mock-store": "^1.5.4",
"sinon": "^9.0.2",
"source-map": "^0.7.4",
"source-map-support": "^0.5.21",
"speed-measure-webpack-plugin": "^1.5.0",
"storybook-addon-jsx": "^7.3.14",