chore: support different JWT CSRF cookie names #25891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
changed the title
craig-rueda
reviewed
Nov 7, 2023
kgabryje
reviewed
Nov 14, 2023
|
|
||
| function getDefaultConfiguration(): ClientConfig { | ||
| const csrfNode = document.querySelector<HTMLInputElement>('#csrf_token'); | ||
| const csrfToken = csrfNode?.value; | ||
|
|
||
| // when using flask-jwt-extended csrf is set in cookies | ||
| const cookieCSRFToken = parseCookie().csrf_access_token || ''; | ||
| const jwtAccessCsrfCookieName = | ||
| bootstrapData.common.conf.JWT_ACCESS_CSRF_COOKIE_NAME; |
There was a problem hiding this comment.
Shouldn't we have a fallback here to 'csrf_access_token'?
There was a problem hiding this comment.
by default JWT_ACCESS_CSRF_COOKIE_NAME is csrf_access_token and that default is set by flask-jwt-extended
dpgaspar
requested review from
craig-rueda
and removed request for
craig-rueda and
michael-s-molina
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
the
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
3 tasks
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently
SupersetClientonly supports flask-jwt-extended default access CSRF cookie name, yet this name can be set using JWT_ACCESS_CSRF_COOKIE_NAME.This PR makes
SupersetClientsupport this configBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION