-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tags): Allow for lookup via ids vs. name in the API #25996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
changed the title
allow for lookup via ids vs. name
chore(tags): allow for lookup via ids vs. name in API
Nov 16, 2023
hughhhh
changed the title
chore(tags): allow for lookup via ids vs. name in API
chore(tags): Allow for lookup via ids vs. name in the API
Nov 16, 2023
hughhhh
requested review from
betodealmeida,
lilykuang and
Antonio-RiveroMartnez
November 16, 2023 20:40
lilykuang
approved these changes
Nov 29, 2023
rusackas
reviewed
Nov 29, 2023
@@ -194,3 +194,20 @@ export function fetchObjects( | |||
.then(({ json }) => callback(json.result)) | |||
.catch(response => error(response)); | |||
} | |||
|
|||
export function fetchObjectsByTagIds( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is fetchObjects
above this just dead code now? I don't see it being used elsewhere.
🏷️ preset:2023.47 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Nov 29, 2023
(cherry picked from commit ee308fb)
9 tasks
michael-s-molina
added
the
v3.1
Label added by the release manager to track PRs to be included in the 3.1 branch
label
Nov 30, 2023
michael-s-molina
pushed a commit
that referenced
this pull request
Dec 4, 2023
(cherry picked from commit ee308fb)
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
(cherry picked from commit ee308fb)
mistercrunch
added
🍒 3.1.0
🍒 3.1.1
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
labels
Mar 8, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Previously we the API only supported queries using the names as way of querying tags, I've updated the API to now accept IDs (better pattern) to allow names to have commas. We discovered the issue in testing and took advantage the opportunity to refactor this piece of code, but also leaving
tags
param for backwards compatibility.TESTING INSTRUCTIONS
ADDITIONAL INFORMATION