fix(database-import): Support importing a DB connection with a version set

[Vitor-Avila]

SUMMARY

Add support for importing a DB connection with a version set.

TESTING INSTRUCTIONS

Unit test added for this case. To manually test it:

1. Create a DB connection.
2. Set a version for this connection in the ADVANCED tab, under the Other section.
3. Export the DB connection.
4. Import it.

ADDITIONAL INFORMATION

• Has associated issue: Fixes Unable to import a DB connection containing the version information filled #26115
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (849ca64) 69.10% compared to head (15de153) 66.91%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26116      +/-   ##
==========================================
- Coverage   69.10%   66.91%   -2.19%     
==========================================
  Files        1940     1940              
  Lines       75869    75870       +1     
  Branches     8445     8445              
==========================================
- Hits        52428    50768    -1660     
- Misses      21266    22927    +1661     
  Partials     2175     2175              

Flag	Coverage Δ
hive	?
mysql	78.13% <100.00%> (-0.03%)	⬇️
postgres	78.25% <100.00%> (+<0.01%)	⬆️
presto	?
python	78.39% <100.00%> (-4.56%)	⬇️
sqlite	76.91% <100.00%> (+<0.01%)	⬆️
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[betodealmeida]

This is great, thanks for the fix!

[michael-s-molina]

@Vitor-Avila shouldn't we fill the version when a new database connection is created from the interface?

[Vitor-Avila]

@Vitor-Avila shouldn't we fill the version when a new database connection is created from the interface?

@michael-s-molina the field is visible in the connection dialog (in the ADVANCED tab under the Other section), however the field is not required. I know it's used for Presto and Dremio, but not all engine dialects have variations on the version value.

the issue was that an export for a connection with a version set couldn't be imported.
Let me know if you have any other questions!